This repository was archived by the owner on Oct 10, 2025. It is now read-only.
PLAT-13615: Remove cookiecutter from demo command #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cruz636
reviewed
Apr 29, 2024
| async function downloadAndExtract(url, target) { | ||
| const rnResponse = await fetch(url); | ||
| if (rnResponse.ok && rnResponse.body) { | ||
| rnResponse.body.pipe(unzipper.Extract({ path: target })); |
There was a problem hiding this comment.
nit: this won't have any side effects? I mean, if the .pipe fails somehow, we are not catching any exception and throwing the error to the User.
Contributor
Author
There was a problem hiding this comment.
Thanks for the comment! Good point... The idea here is that these errors will bubble up to the main dispatch call and the error will be sent to sentry. That's why I also throw the error in the if/else instead of just showing an error message.
But I think we could improve it a bit since this makes the user see an unhandled async error message from Node. I made a small change in 9db1bd4 so that the error messages are routed to sentry and also "parsed". Improvements to the parsing function will probably require some product input, so I will leave it as is for now!
danielsousaio
approved these changes
Apr 29, 2024
cruz636
approved these changes
Apr 29, 2024
alaisgomes
added a commit
that referenced
this pull request
May 14, 2024
…14140948 Release CLI: Version 3.2.0 7fb8ee9 Merge pull request #106 from crowdbotics/develop b1197b9 Merge pull request #104 from crowdbotics/ASBLY-26 d224830 added check for not installed local CLI fbac8ff fix: replace unzip library (#102) fc88283 Merge pull request #91 from crowdbotics/ASBLY-29 0ddc7fe Merge branch 'develop' into ASBLY-29 a1f0e4d Merge pull request #93 from crowdbotics/ASBLY-26 b9f4c7b updated docs link eb7a7ae PLAT-14510: Adding verbose to more commands (#95) 1592be7 updated yarn lock file 01bf626 Merge branch 'develop' into ASBLY-26 ecdb7ec flatten the checks and added semver for version comparison 58397aa PLAT-14510 cli verbose mode (#94) af1dd0c ASBLY-29 Added bug for saving opt in 86e5edc ASBLY-29 changed to section 4ef800f PLAT-13615: Remove cookiecutter from demo command (#85) c9ee552 ASBLY-29 replaced list with constant 45ebd0c ASBLY-29 removed message about analytics 6e7002b ASBLY-29 added a message about analytics data e42c393 checking, printing and comparing local and registry version of crowdbotics CLI 5899686 Merge pull request #92 from crowdbotics/main 434d77d ASBLY-29 added required login to use commands, if not logged in login script will run, some commands that do not require login and also some cleanup 3f54ece Merge pull request #90 from crowdbotics/PLAT-14519-cli-delay 6938ed6 PLAT-14519: Resolving issue with segment library hanging CLI 5fd41a3 ASBLY-29 changed initial opt in and state of having set initial opt in to a different name. Commands for opt in and opt out. Keep other logic same.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
PLAT-13615
Related PRs: crowdbotics/django-scaffold#744 crowdbotics/react-native-scaffold#431
Type of PR
Changes introduced
democommand to download a copy of the scaffold to generate theTest and review
node index.js demo --source PLAT-13615(the source is because the zip files are not in master yet)