Skip to content

Conversation

@alaisgomes
Copy link
Contributor

Ticket

PLAT-13615
Related tickets:
Related PRs:

Type of PR

  • Bugfix
  • New feature
  • Minor changes

Did you make changes to the scaffold?

Changes introduced

New script to generate a demo version of the scaffold
Pre-compiled demo version is available as a zip file

Test and review

Script works
zip is generated and updated (linux only)

scripts/demo.js Outdated
const rnCookieCutterCommand = [
"pipenv run cookiecutter",
"./dist/cookie",
"--checkout master",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This argument shouldn't be needed given the local path argument above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops an oversight. Updated with a21faaf

danielsousaio
danielsousaio previously approved these changes Apr 29, 2024
@alaisgomes alaisgomes merged commit a10f1bf into develop May 1, 2024
@alaisgomes alaisgomes deleted the PLAT-13615 branch May 1, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants