Skip to content

Unify sqlite build flag - #4525

Merged
blotus merged 2 commits into
crowdsecurity:masterfrom
zc-devs:fix-sqlite-build-flag
Jul 1, 2026
Merged

Unify sqlite build flag#4525
blotus merged 2 commits into
crowdsecurity:masterfrom
zc-devs:fix-sqlite-build-flag

Conversation

@zc-devs

@zc-devs zc-devs commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

There is a component named db_sqlite (1, 2, 3, 4).

In order to disable a component, Makefile suggests to apply no_ prefix to a component name. For example, no_db_postgres. However, sqlite doesn't follow the convention: 1, 2.

So, this PR changes flag names in order to comply with the convention.

@github-actions

Copy link
Copy Markdown

@zc-devs: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions

Copy link
Copy Markdown

@zc-devs: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@zc-devs

zc-devs commented Jun 27, 2026

Copy link
Copy Markdown
Contributor Author

/kind fix
/area local-api
/area cscli

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.90%. Comparing base (b962bc0) to head (35d9210).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4525   +/-   ##
=======================================
  Coverage   63.89%   63.90%           
=======================================
  Files         478      478           
  Lines       34298    34310   +12     
=======================================
+ Hits        21915    21925   +10     
- Misses      10227    10229    +2     
  Partials     2156     2156           
Flag Coverage Δ
bats 46.48% <ø> (-0.02%) ⬇️
unit-linux 37.34% <ø> (+0.01%) ⬆️
unit-windows 25.99% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@blotus
blotus merged commit 352d4f4 into crowdsecurity:master Jul 1, 2026
15 of 16 checks passed
@zc-devs
zc-devs deleted the fix-sqlite-build-flag branch July 1, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants