Skip to content

challenge: tolerate strings instead of struct in FP payload - #4655

Merged
blotus merged 1 commit into
masterfrom
challenge-fp-flex-struct
Sep 3, 2026
Merged

challenge: tolerate strings instead of struct in FP payload#4655
blotus merged 1 commit into
masterfrom
challenge-fp-flex-struct

Conversation

@blotus

@blotus blotus commented Sep 3, 2026

Copy link
Copy Markdown
Member

Fixes #4654

Now, all structs in the fingerprint have a custom unmarshaler that handles the source attribute being either a string or the actual type (similarly to FlexInt/FlexBool) as fpscanner will sometimes return ERROR instead of the actual struct.

If a string is returned, we will simply use the empty value of the struct.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@blotus

blotus commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

/kind fix
/area appsec

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.68%. Comparing base (cc76dbb) to head (77c8e2a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4655      +/-   ##
==========================================
+ Coverage   64.65%   64.68%   +0.02%     
==========================================
  Files         521      522       +1     
  Lines       39800    39859      +59     
==========================================
+ Hits        25733    25783      +50     
- Misses      11668    11672       +4     
- Partials     2399     2404       +5     
Flag Coverage Δ
bats 41.07% <0.00%> (-0.12%) ⬇️
unit-linux 41.91% <100.00%> (+0.09%) ⬆️
unit-windows 30.50% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@blotus
blotus merged commit e01220d into master Sep 3, 2026
16 of 17 checks passed
@blotus
blotus deleted the challenge-fp-flex-struct branch September 3, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

appsec challenge: Brave users can't pass the bot challenge (keyboard fingerprint signal sent as a string, payload rejected)

2 participants