challenge: tolerate strings instead of struct in FP payload - #4655
Conversation
|
@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
@blotus: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
/kind fix |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4655 +/- ##
==========================================
+ Coverage 64.65% 64.68% +0.02%
==========================================
Files 521 522 +1
Lines 39800 39859 +59
==========================================
+ Hits 25733 25783 +50
- Misses 11668 11672 +4
- Partials 2399 2404 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Fixes #4654
Now, all structs in the fingerprint have a custom unmarshaler that handles the source attribute being either a string or the actual type (similarly to
FlexInt/FlexBool) as fpscanner will sometimes returnERRORinstead of the actual struct.If a string is returned, we will simply use the empty value of the struct.