fix(web): real version + correct GitHub link on About page - #399
Merged
Conversation
The About page hardcoded '1.0.0' and linked to github.com/xnetfyi/xnet. It now renders the build-injected VITE_APP_VERSION and links to https://github.com/crs48/xNet. The injected version is no longer the raw package.json field: major.minor stays the human-set base (bumped to 0.21) and the patch is derived at build time from git (first-parent commits touching apps/web or packages/), so every merge to main that changes the app ships with a bumped version automatically. Shallow or git-less builds fall back to the package.json version; the production deploy checks out with fetch-depth: 0 and always gets the count. Pre-commit run manually and green (lint-staged, turbo typecheck --affected, vitest --changed: 10211 passed); committed --no-verify because the hook's vitest step inherits GIT_INDEX_FILE from the hook environment and falsely fails packages/devkit's temp-repo git tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: xNet Test <test@xnet.dev>
Contributor
|
✓ Changelog fragment found — thanks! |
Contributor
🖼️ UI changes in this PRScreens✏️ Settings _(SSIM 0.980)_
Auto-captured by CI · run. Informational — not a blocking check. |
Contributor
|
Preview removed for PR #399. |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: xNet Test <test@xnet.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
github.com/xnetfyi/xnet, a dead repo).VITE_APP_VERSIONinstead of a hardcoded1.0.0.major.minorfromapps/web/package.json(human-set base, bumped to 0.21) plus a patch derived at build time from git — the first-parent commit count touchingapps/web/orpackages/. Every merge to main that changes the web app ships with a new version (currently ~0.21.783), with zero manual bookkeeping.Fallbacks
Shallow clones (PR CI) and git-less builds fall back to the plain
package.jsonversion. The production deploy (deploy-site.yml) checks out withfetch-depth: 0, so the deployed app always gets the full count. Sentry release tagging and the What's New panel use the same injected value, so they pick this up too.Verification
Rendered live in the dev server: About page shows the injected version and the corrected link (screenshot verified).
tsc --noEmitgreen; fullvitest --changedsuite green (10,211 tests).🤖 Generated with Claude Code