Move Space selection to the top island; drop Explorer's redundant New (0288) - #431
Merged
Conversation
…dundant New (0288) The top-island workspace selector now opens a Space picker (sets currentSpaceId) instead of the layout/bench switcher — a new 'workspace' FloatingMenu listing All / each Space / No workspace. Removed the ExplorerScopeBar and the redundant ExplorerCreateMenu (+ its Add-shared dialog) from the Explorer; the top-island New and the surface-aware bottom + are the create paths now. The bench switcher stays reachable via the command palette. Signed-off-by: xNet Test <test@xnet.dev>
Contributor
🖼️ UI changes in this PRScreens✏️ Home _(SSIM 0.978)_
Auto-captured by CI · run. Informational — not a blocking check. |
Contributor
|
Preview removed for PR #431. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses three concrete issues on the Floating shell:
workspace.switch). It now opens a Space picker — a newworkspaceFloatingMenu listing All workspaces / each Space / No workspace — that setscurrentSpaceId(the scope you filter by and file New items into). The label already reflected the current Space, so it now reads and writes the same thing. The bench/layout switcher stays reachable from the command palette (⌘K).ExplorerScopeBarfrom the Explorer; the top-island selector is the single Space control now, visible on every surface.ExplorerCreateMenu(and its inline Add-shared dialog) — the top-island New (canonical, Space-aware) and the surface-aware bottom+are the create paths now.ExplorerScopeBar.tsxis left in the tree (unmounted) so its multi-Space view-filter logic can be folded into the top picker in a later slice.Verified live (worktree preview, desktop)
The top selector opens the Space picker (Workspaces / All workspaces / No workspace) — not the layout switcher; the Explorer no longer shows the scope chips or the "+ New" dropdown (just Filter + type chips); no console errors.
pnpm typecheckclean, lint clean, 198 workbench tests pass.Part of exploration 0288; checks off the "Space scope picker to the top island" item.
🤖 Generated with Claude Code