Dev-tools toggles the panel; fix Assistant dock margins - #432
Merged
Conversation
…ins (0287) The docked dev-tools wrench now toggles the devtools panel directly (like the old FAB / ⌘⇧D) instead of opening a popover menu. The floating Assistant dock's offsets double-counted the root padding + status island (it's positioned inside the body row, not the window), so it floated with too much margin on the bottom/ left/right; corrected to an 8px gap to the sidebar, right island, and status island — matching every other island. Signed-off-by: xNet Test <test@xnet.dev>
Contributor
🖼️ UI changes in this PRScreens✏️ Home _(SSIM 0.923)_
Auto-captured by CI · run. Informational — not a blocking check. |
Contributor
|
Preview removed for PR #432. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small Floating-shell fixes.
@xnetjs/devtoolspanel directly — the same as the old floating FAB and ⌘⇧D. Removed the popover, portal, and menu entirely.bottom = 11 + 32 + 8 = 51,left = 11 + sidebarWidth + 8, …). So it floated up ~51px and inset ~11px on each side. Corrected to body-row-relative offsets: 8px gap to the sidebar (left), the right island (right), and the status island (bottom) — matching every other island.Verified live (worktree preview, desktop)
Measured the Assistant's gaps: 8px to the sidebar, 8px to the status island, right edge aligned with the editor (11px root padding, like all islands). The dev-tools button opens/closes the devtools panel with no popover. Typecheck + lint clean, 198 workbench tests pass, no console errors.
🤖 Generated with Claude Code