Host Settings section nav in the contextual bottom island (0288) - #433
Merged
Conversation
…(0288) The Settings page kept its own left nav. Lift the active section to a URL search param (/settings?section=…, validated), extract the section list to a shared settings-sections module, and render that nav in the workbench's bottom island whenever /settings is open — the section content fills the main area, matching the list-left/content-right pattern of every other surface. Signed-off-by: xNet Test <test@xnet.dev>
Contributor
🖼️ UI changes in this PRScreens✏️ Settings _(SSIM 0.847)_
Auto-captured by CI · run. Informational — not a blocking check. |
Contributor
|
Preview removed for PR #433. |
A non-route metadata module under routes/ tripped the electron-parity check (every routes/ file needs a desktop decision) and would make TanStack Router generate a bogus route. Moved to lib/settings-sections.ts. Signed-off-by: xNet Test <test@xnet.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the Settings section tabs into the lower-left contextual island when Settings is open — the master-detail pattern the rest of the workbench uses.
What changed
settings-sections.tsx(new) — the section list (id/label/icon) + type +asSettingsSectionvalidator, extracted so the sidebar can import it without pulling in every settings panel./settingsroute — the active section now rides in the URL (?section=…, validated viavalidateSearch) instead of local state; the page renders just the section content (full-width), its old left<nav>removed.SettingsSectionsNav(new) — the section list, rendered in the bottom island when/settingsis open; selecting a section navigates/settings?section=…, and the content follows in the main area.BottomIslandis now route-aware: on/settingsit shows the Settings nav (gear header); otherwise the active surface, as before.Bonus: the active section is now deep-linkable (
/settings?section=network).Verified live (worktree preview, desktop)
Opening
/settingsshows the section nav in the bottom island (Profile active) with the Profile content in the main area; clicking Appearance updates the URL to/settings?section=appearance, highlights it, and swaps the content. Full typecheck (94/94), lint clean, 198 workbench tests pass, no console errors.Part of exploration 0288 (contextual bottom island per surface).
🤖 Generated with Claude Code