Make Settings a proper editor tab (0288) - #435
Merged
Merged
Conversation
Register 'settings' as a singleton TabNodeType: add it to TAB_NODE_TYPES, TAB_VIEWS (gear icon, /settings), tabFromPathname (/settings, ignoring the ?section= param so section switches stay on one tab), navigateToNode, and HOSTED_VIEWS (a hint for the rare split/background case). Update the two tabs.test assertions that used /settings as their non-tab example. Signed-off-by: xNet Test <test@xnet.dev>
Contributor
🖼️ UI changes in this PRNo visual differences detected in the changed UI. |
Contributor
|
Preview removed for PR #435. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes Settings open as a tab in the editor's pill-tab bar, like documents and the other singleton surfaces (Tasks, Meetings, …).
What changed
settingsas a singletonTabNodeType: added toTAB_NODE_TYPES,TAB_VIEWS(gear icon →/settings),tabFromPathname(/settings, ignoring the?section=param so switching sections stays on the one tab),navigateToNode(clicking the tab routes to/settings), andHOSTED_VIEWS(a hint for the rare split/background case; the active group renders the real route outlet).tabs.testassertions that used/settingsas their example of a non-tab route (now/discover).Verified live (worktree preview, desktop)
Opening Settings (profile menu → Settings) adds a Settings tab (active, gear icon) at
/settings; the section nav sits in the bottom island and the content fills the main area. Switching sections (e.g. Network) keeps exactly one Settings tab (/settings?section=network); clicking another tab then the Settings tab round-trips the URL back to/settings. Full typecheck (94/94), lint clean, 198 workbench tests pass (2 outdated assertions updated), no console errors.🤖 Generated with Claude Code