feat(app): remove the pin-tab button from the tab strip - #436
Merged
Conversation
The inline pin/unpin button on each tab took up space for a rarely-used action. Pin and unpin remain available from the tab's right-click context menu, so no functionality is lost — pinned tabs still shrink to their icon and lose the close button. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: xNet Test <test@xnet.dev>
Contributor
🖼️ UI changes in this PRNo visual differences detected in the changed UI. |
Contributor
|
Preview removed for PR #436. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the inline pin / unpin button that appeared on each tab in the workbench tab strip. It occupied space (revealed on hover for unpinned tabs; always shown for pinned tabs) for a rarely-used action.
Why
Per the request: the button just eats up UI space and isn't very useful.
No functionality lost
Pin and unpin remain fully reachable from the tab's right-click context menu (
Pin tab/Unpin tab), which already existed. Pinned tabs still shrink to their icon and lose the close button; the only change is that the pinned tab no longer renders an inline unpin button —TabActionsreturnsnullfor pinned tabs.The store action
setTabPinned, the keyboard/close-guard behavior, and thePin/PinOfficon imports (still used by the context menu) are untouched.Verification
apps/web/src/workbench/*tests pass (198/198), includingstate.test.tspin/unpin coverage.Adds a changelog fragment (
apptag). No changeset —apps/webis a private app.🤖 Generated with Claude Code