feat(app): plugin details view with install button in marketplace - #443
Merged
Conversation
Clicking a marketplace card now opens a details modal (name, version, category, author, description, install/star/license stats, homepage, requested capabilities, and contributions) with an Install button that drives the existing consent-gated install flow. The inline card Install button is preserved via stopPropagation. Signed-off-by: xNet Test <test@xnet.dev> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
✓ Changelog fragment found — thanks! |
Signed-off-by: xNet Test <test@xnet.dev> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
🖼️ UI changes in this PRNo visual differences detected in the changed UI. |
Contributor
|
Preview removed for PR #443. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a plugin details view to the in-app marketplace browser (Settings → Plugins → Browse). Clicking a plugin card now opens a details modal, and the details view has an Install button.
Changes (
apps/web/src/components/MarketplaceView.tsx)MarketplaceCardis now arole="button"element (keyboard-accessible, hover affordance) that opens the details view. The inline card Install button is preserved viastopPropagation.PluginDetailsDialog— a modal (matching the existingConsentDialogstyling) showing the full plugin info: icon, name, version, category, author, description, a stats row (installs, stars, license, Homepage link), the requested-access capability list, and the plugin's contributions ("Adds"). The footer holds the Install button for available plugins, or an "Installed"/"Built-in" status pill otherwise.handleInstall(consent gate +registry.install), so the capability-consent dialog still surfaces when required and the footer reactively flips to "Installed" via the registryonChangesubscription.Verification
Typecheck passes. Exercised end-to-end in the browser preview:
Note:
apps/webis a private app, so no changeset is required.🤖 Generated with Claude Code