fix(mentions): match @handle in comment, task, and page mention pickers - #464
Merged
Conversation
Contributor
|
✓ Changelog fragment found — thanks! |
added 2 commits
July 10, 2026 16:01
Setting a username (@handle, 0172 phase 4) only wired handle matching into the chat composer picker — every other @mention surface filtered on display name and DID alone, so a freshly set handle surfaced nobody: - comments and task inputs: TaskPersonOption now carries the handle, filterTaskPeople matches it, and useCommentPeople/useWorkspacePeople resolve it from Profile nodes (task surfaces previously resolved no profile metadata at all — they now show real names too) - page editor mentions: TaskMentionSuggestion carries the handle, filterSuggestions matches it, and buildPersonMentionSuggestions passes it through from profiles - chat: mergeMentionables no longer drops self, so typing your own new @handle finds you — listed last and labelled "(you)" so it never crowds out collaborators; self-mentions stay notification-safe (rules already ignore self-authored changes) Mention menus render the muted @handle next to the display name so it is visible why an option matched. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: xNet Test <test@xnet.dev>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: xNet Test <test@xnet.dev>
crs48
force-pushed
the
claude/username-autocomplete-bug-482cc9
branch
from
July 10, 2026 23:01
89ab23c to
293465e
Compare
Contributor
|
Preview removed for PR #464. |
Contributor
🖼️ UI changes in this PRInteractionsAuto-captured by CI · run. Informational — not a blocking check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Setting a username (@handle) in your profile did not surface you in the @mention autocomplete inside chats or comments.
0172 phase 4 (
8fdac91ad) added handle matching only to the chat composer's picker filter. Every other mention surface — comments, task inputs, and in-page editor mentions — filtered on display name and DID alone, so typing a handle that shares nothing with the display name matched nobody. And in chat,mergeMentionablesdeliberately removed self from the candidate list, so testing your own new handle failed there too.Fix
TaskPersonOption/filterTaskPeople): the option now carries the optionalhandle, the filter matches it, anduseCommentPeople/useWorkspacePeopleresolve it from Profile nodes. Task surfaces previously resolved no profile metadata at all — they now show real display names instead of truncated DIDs.TaskMentionSuggestion/filterSuggestions/buildPersonMentionSuggestions): same treatment for the in-editor @mention popup.mergeMentionables): self is kept as a candidate — listed last and labelled "(you)" so it never crowds out collaborators. Notification rules already ignore self-authored changes, so self-mentions can't self-notify.@handlenext to the display name so it's visible why an option matched.Verified
filterTaskPeople,mergeMentionables(self-last + handle carry-through),collectWorkspacePeopleprofile resolution, andbuildPersonMentionSuggestions.@wiz→ "@chris Test (you)"; empty@lists collaborators first, self last@wiz→ "Chris Test — @wizard · You"@wiz→ "Chris Test @wizard (you)"pnpm typecheckgreen; 1683 tests acrossapps/web,packages/ui,packages/editorpass.All touched packages (
@xnetjs/ui,@xnetjs/editor,xnet-web) are private — no changeset required.🤖 Generated with Claude Code