Fix decryption for Riddle Joker#185
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you dump the current Formats.dat, you'll see:
Notice that
m_key1andm_key2are both 0 when they should've been0xaaaaaaaaand0x55555555respectively. This is probably due to 01636ac which adds these two fields toRiddleCxCrypt(instead of having them hardcoded).I fixed Formats.dat with the following:
To verify that this works, try unpacking the game's official patch available here (direct link). (This is an NSIS installer, you can either run it and find the patch manually or extract patch.xp3 from it directly with NanaZip)
Prior to the fix, the files extracted from the patch all have a few bytes broken (though most of the bytes are correct).