Add Accrescent #116
Add Accrescent #116
Conversation
WalkthroughThis pull request involves modifications to the internationalization (i18n) files for German and English languages, specifically in the Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
layouts/partials/android-accrescent.html (1)
1-8: Enhance schema.org metadata for better SEO.Consider adding these recommended fields for better search engine visibility:
operatingSystemVersiondownloadUrlofferswith pricing informationaggregateRatingif available<div class="text-center" itemscope itemtype="http://schema.org/SoftwareApplication"> <meta itemprop="name" content="Cryptomator"/> <meta itemprop="description" content="A free software to encrypt your cloud files."/> <meta itemprop="applicationCategory" content="Productivity"/> <meta itemprop="softwareVersion" content="{{ .Site.Params.releases.android.version }}"/> <meta itemprop="applicationSubCategory" content="Encryption"/> <meta itemprop="image" content="{{ "/img/logo.png" | absURL }}"/> <meta itemprop="operatingSystem" content="Android"/> + <meta itemprop="operatingSystemVersion" content="8.0"/> + <meta itemprop="downloadUrl" content="https://accrescent.app/app/org.cryptomator"/> + <div itemprop="offers" itemscope itemtype="http://schema.org/Offer"> + <meta itemprop="price" content="0"/> + <meta itemprop="priceCurrency" content="USD"/> + </div> </div>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
static/img/downloads/accrescent-badge.pngis excluded by!**/*.png
📒 Files selected for processing (4)
i18n/de.yaml(1 hunks)i18n/en.yaml(1 hunks)layouts/android/single.html(1 hunks)layouts/partials/android-accrescent.html(1 hunks)
🔇 Additional comments (3)
layouts/android/single.html (1)
21-24: LGTM! Clean integration of the new section.The Accrescent section is properly integrated into the existing layout structure.
i18n/en.yaml (1)
95-96: Verify the scope of translation changes.A large number of translations are being removed that seem unrelated to adding Accrescent support. Consider splitting these changes into a separate PR for better review and tracking.
i18n/de.yaml (1)
95-96: LGTM! Consistent translation across languages.The German translation for
android_accrescent_exclusionmatches the English version and maintains consistency with the existing exclusion messages.
| <a href="https://accrescent.app/app/org.cryptomator" role="button" class="plausible-event-name=downloads-android-accrescent"> | ||
| <img class="h-10 mx-auto lazyload mb-4" data-src="/img/downloads/accrescent-badge.png"> | ||
| </a> |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add security attributes to external link and improve accessibility.
The external link to Accrescent should have security attributes and the image should have alt text.
- <a href="https://accrescent.app/app/org.cryptomator" role="button" class="plausible-event-name=downloads-android-accrescent">
- <img class="h-10 mx-auto lazyload mb-4" data-src="/img/downloads/accrescent-badge.png">
+ <a href="https://accrescent.app/app/org.cryptomator" role="button" rel="noopener noreferrer" target="_blank" class="plausible-event-name=downloads-android-accrescent">
+ <img class="h-10 mx-auto lazyload mb-4" data-src="/img/downloads/accrescent-badge.png" alt="Download on Accrescent">
</a>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <a href="https://accrescent.app/app/org.cryptomator" role="button" class="plausible-event-name=downloads-android-accrescent"> | |
| <img class="h-10 mx-auto lazyload mb-4" data-src="/img/downloads/accrescent-badge.png"> | |
| </a> | |
| <a href="https://accrescent.app/app/org.cryptomator" role="button" rel="noopener noreferrer" target="_blank" class="plausible-event-name=downloads-android-accrescent"> | |
| <img class="h-10 mx-auto lazyload mb-4" data-src="/img/downloads/accrescent-badge.png" alt="Download on Accrescent"> | |
| </a> |
|
The attributes for external links are also my only concern. Looks good otherwise. |
This is copied from https://github.com/cryptomator/cryptomator.github.io/blob/develop/content/downloads/android.en.html#L24-L26, so if we want to change it (what we should), we should change it everywhere where we use this tag and which is imo out of scope of this PR. I'll create another PR for it within the next days. |
overheadhunter
left a comment
overheadhunter
left a comment
There was a problem hiding this comment.
Approved under aforementioned condition
No description provided.