Skip to content

Add Accrescent #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Add Accrescent #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions i18n/de.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@
translation: "Google Drive ist aufgrund proprietärer Abhängigkeiten ausgeschlossen."
- id: android_fdroid_cloud_exclusion_hint
translation: "Einen detaillierten Vergleich aller Varianten findest du in unserer <a class=\"text-sm no-underline hover:underline\" href=\"https://docs.cryptomator.org/en/latest/android/setup\" target=\"_blank\">Dokumentation</a>."
- id: android_accrescent_exclusion
translation: "Google Drive ist aufgrund proprietärer Abhängigkeiten ausgeschlossen."

# Blog
- id: blob_post_author_prefix
Expand Down
2 changes: 2 additions & 0 deletions i18n/en.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@
translation: "Google Drive is excluded due to proprietary dependencies."
- id: android_fdroid_cloud_exclusion_hint
translation: "A detailed comparison of all variants can be found in our <a class=\"text-sm no-underline hover:underline\" href=\"https://docs.cryptomator.org/en/latest/android/setup\" target=\"_blank\">docs</a>."
- id: android_accrescent_exclusion
translation: "Google Drive is excluded due to proprietary dependencies."

# Blog
- id: blob_post_author_prefix
Expand Down
4 changes: 4 additions & 0 deletions layouts/android/single.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ <h1>{{ .Title }}</h1>
<section>
{{ partial "android-fdroid.html" . }}
</section>

<section>
{{ partial "android-accrescent.html" . }}
</section>
</div>
</div>
</div>
Expand Down
26 changes: 26 additions & 0 deletions layouts/partials/android-accrescent.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
<div class="text-center" itemscope itemtype="http://schema.org/SoftwareApplication">
<meta itemprop="name" content="Cryptomator"/>
<meta itemprop="description" content="A free software to encrypt your cloud files."/>
<meta itemprop="applicationCategory" content="Productivity"/>
<meta itemprop="softwareVersion" content="{{ .Site.Params.releases.android.version }}"/>
<meta itemprop="applicationSubCategory" content="Encryption"/>
<meta itemprop="image" content="{{ "/img/logo.png" | absURL }}"/>
<meta itemprop="operatingSystem" content="Android"/>

<div class="rounded shadow bg-white">
<div class="prose prose-sm max-w-none md:max-w-none px-4 py-2 border-b border-primary">
<h3>Accrescent</h3>
</div>
<div class="p-4">
<div class="prose prose-sm max-w-none mb-4">
<p>Minimum: Android 8.0</p>
</div>
<a href="https://accrescent.app/app/org.cryptomator" role="button" class="plausible-event-name=downloads-android-accrescent">
<img class="h-10 mx-auto lazyload mb-4" data-src="/img/downloads/accrescent-badge.png">
</a>
Comment on lines +18 to +20
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Add security attributes to external link and improve accessibility.

The external link to Accrescent should have security attributes and the image should have alt text.

-      <a href="https://accrescent.app/app/org.cryptomator" role="button" class="plausible-event-name=downloads-android-accrescent">
-        <img class="h-10 mx-auto lazyload mb-4" data-src="/img/downloads/accrescent-badge.png">
+      <a href="https://accrescent.app/app/org.cryptomator" role="button" rel="noopener noreferrer" target="_blank" class="plausible-event-name=downloads-android-accrescent">
+        <img class="h-10 mx-auto lazyload mb-4" data-src="/img/downloads/accrescent-badge.png" alt="Download on Accrescent">
       </a>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<a href="https://accrescent.app/app/org.cryptomator" role="button" class="plausible-event-name=downloads-android-accrescent">
<img class="h-10 mx-auto lazyload mb-4" data-src="/img/downloads/accrescent-badge.png">
</a>
<a href="https://accrescent.app/app/org.cryptomator" role="button" rel="noopener noreferrer" target="_blank" class="plausible-event-name=downloads-android-accrescent">
<img class="h-10 mx-auto lazyload mb-4" data-src="/img/downloads/accrescent-badge.png" alt="Download on Accrescent">
</a>

<div class="prose prose-sm max-w-none md:max-w-none mb-4">
<p>{{ ":x:" | emojify }} {{ i18n "android_accrescent_exclusion" | safeHTML }}</p>
</div>
</div>
</div>
</div>
Binary file added static/img/downloads/accrescent-badge.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.