Skip to content

detector for storage optimizations by reordering struct variables#1346

Open
mavlevin wants to merge 27 commits into
masterfrom
dev-optimize-var-order
Open

detector for storage optimizations by reordering struct variables#1346
mavlevin wants to merge 27 commits into
masterfrom
dev-optimize-var-order

Conversation

@mavlevin
Copy link
Copy Markdown

No description provided.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 15, 2022

CLA assistant check
All committers have signed the CLA.

@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Aug 15, 2022

This pull request introduces 1 alert when merging a340075 into a277925 - view on LGTM.com

new alerts:

  • 1 for Unused import

@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Aug 20, 2022

This pull request introduces 2 alerts when merging 94d5f8a into 243c6da - view on LGTM.com

new alerts:

  • 2 for Unused import

@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Aug 20, 2022

This pull request introduces 2 alerts when merging e5d172d into 243c6da - view on LGTM.com

new alerts:

  • 2 for Unused import

@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Aug 20, 2022

This pull request introduces 2 alerts when merging ce03221 into 78397b9 - view on LGTM.com

new alerts:

  • 2 for Unused import

@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Aug 20, 2022

This pull request introduces 2 alerts when merging 703b023 into 78397b9 - view on LGTM.com

new alerts:

  • 2 for Unused import

@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Aug 20, 2022

This pull request introduces 2 alerts when merging 94f10f5 into 78397b9 - view on LGTM.com

new alerts:

  • 2 for Unused import

@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Aug 22, 2022

This pull request introduces 2 alerts when merging 43c44c8 into 78397b9 - view on LGTM.com

new alerts:

  • 2 for Unused import

@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Aug 30, 2022

This pull request introduces 2 alerts when merging 2b987a2 into 719e4e9 - view on LGTM.com

new alerts:

  • 2 for Unused import

@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Aug 30, 2022

This pull request introduces 2 alerts when merging 8adeb8d into 719e4e9 - view on LGTM.com

new alerts:

  • 2 for Unused import

Comment thread slither/detectors/variables/optimize_variable_order.py Outdated
Comment thread slither/detectors/variables/optimize_variable_order.py Outdated
@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Nov 11, 2022

This pull request introduces 2 alerts when merging 2d7099d into 440ac4b - view on LGTM.com

new alerts:

  • 2 for Unused import


WIKI = "https://github.com/trailofbits/slither/wiki/optimal-variable-order"
WIKI_TITLE = "Optimal Variable Order"
WIKI_DESCRIPTION = "Detect optimal variable order in contract storage layouts and struct definitions to decrease the number of slots used."
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description seems to indicate that the script will actually find an optimal ordering, but it's not guaranteed. The algorithm is only heuristic, so there may be tighter packings.

@dguido dguido changed the base branch from dev to master January 15, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants