Skip to content

Make COPY work in public links in spaces #5284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jessegeens merged 1 commit into from
Sep 1, 2025
Merged

Make COPY work in public links in spaces #5284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/unreleased/fix-copy-pl-spaces.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Bugfix: Make COPY work in public links in spaces

https://github.com/cs3org/reva/pull/5284/files
2 changes: 1 addition & 1 deletion internal/http/services/owncloud/ocdav/copy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func (s *svc) handlePathCopy(w http.ResponseWriter, r *http.Request, ns string)
}

// For the destination, we still need to handle this ourselves
if s.c.SpacesEnabled {
if s.c.SpacesEnabled && ns != "/public" {
dstSpaceID, dstRelPath := router.ShiftPath(dst)
_, spaceRoot, ok := spaces.DecodeStorageSpaceID(dstSpaceID)
if !ok {
Expand Down
4 changes: 3 additions & 1 deletion internal/http/services/owncloud/ocdav/ocdav.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,9 @@ func extractDestination(r *http.Request) (string, error) {
baseURI := r.Context().Value(ctxKeyBaseURI).(string)
// TODO check if path is on same storage, return 502 on problems, see https://tools.ietf.org/html/rfc4918#section-9.9.4
// Strip the base URI from the destination. The destination might contain redirection prefixes which need to be handled
return strings.TrimPrefix(dstURL.Path, baseURI), nil
destination := strings.TrimPrefix(dstURL.Path, baseURI)
return destination, nil

}

// replaceAllStringSubmatchFunc is taken from 'Go: Replace String with Regular Expression Callback'
Expand Down