Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
jessegeens
force-pushed
the
refactor/eosfs-auth
branch
29 times, most recently
from
b1d65d3 to
3eb4372
Compare
jessegeens
force-pushed
the
refactor/eosfs-auth
branch
5 times, most recently
from
5a04607 to
f11ca3f
Compare
jessegeens
force-pushed
the
refactor/eosfs-auth
branch
3 times, most recently
from
0c48f71 to
e95b9c1
Compare
jessegeens
force-pushed
the
refactor/eosfs-auth
branch
5 times, most recently
from
34d2c4f to
e07a916
Compare
| return invalidAuth(), fmt.Errorf("eosfs: no user found in context") | ||
| } | ||
|
|
||
| if fs.conf.ForceSingleUserMode { |
There was a problem hiding this comment.
This code is repeated. Seems a good candidate for a split into another function.
There was a problem hiding this comment.
Maybe we can even consider getting rid of it? I think this stems from when owncloud did everything under one user. But today I don't really see a use case for this
There was a problem hiding this comment.
If that is the case and we don't have a reason to keep it, go ahead. @glpatcern, with your history knowledge, what you think?
There was a problem hiding this comment.
Yes, as far as I remember this was the operating model of ownCloud 10 and older, and we never used it. Let's drop it.
jessegeens
force-pushed
the
refactor/eosfs-auth
branch
from
e07a916 to
e5327fa
Compare
diocas
left a comment
diocas
left a comment
There was a problem hiding this comment.
Fine to merge, but I would still prefer to see this line once and used in different places:
nobody := uint64(65534)I don't see why we need to create a cyclical dependency for this.
* Use a (configurable) dedicated service account for accesses made by external accounts, instead of impersonating the owner or using a token * Renamed the different types of auth to be more clear (e.g. cboxAuth became systemAuth) * Added a `InvalidAuthorization` to be returned instead of an empty auth; because empty auth maps to the system user (which is a sudo'er)
jessegeens
force-pushed
the
refactor/eosfs-auth
branch
from
e5327fa to
d390ff2
Compare
jessegeens
force-pushed
the
refactor/eosfs-auth
branch
from
f6a8c1f to
6727694
Compare
3 participants
instead of impersonating the owner or using a token
InvalidAuthorizationto be returned instead of an empty auth; because empty auth maps to the system user (which is a sudo'er)