Submeters for METER and LOADMETER #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nealkruis
approved these changes
Apr 28, 2023
There was a problem hiding this comment.
@chipbarnaby just a couple comments on confusing names and unrelated changes.
| return rc; | ||
| } // cgSubMeterSetup | ||
| //------------------------------------------------------------------------------ | ||
| RC SUBMETERSEQ::smsq_Setup() // derive submeter sequences |
There was a problem hiding this comment.
...nm. This is just a prefix. The context should be (mostly) clear based on the class name.
There was a problem hiding this comment.
smsq = submeter sequence
Comment on lines
+4691
to
+4692
| wh_qLoss = BtuperkWh * wh_HPWH.hw_qLoss; // tank loss, + = to surround | ||
| wh_qEnv = BtuperkWh * wh_HPWH.hw_qEnv; |
There was a problem hiding this comment.
Doesn't seem relevant to this PR.
There was a problem hiding this comment.
It is not. Work on DHW energy balance became entangled.
| return true; | ||
| } // DGRAPH::dg_TopologicalSort | ||
| //----------------------------------------------------------------------------- | ||
| bool DGRAPH::dg_TopologicalSortDFS( |
There was a problem hiding this comment.
DFS = depth first search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial implementation of submeters for METER and LOADMETER
Also includes incomplete DHWSYSRES accounting fixes.