Skip to content

Conversation

@chipbarnaby
Copy link
Contributor

@chipbarnaby chipbarnaby commented May 18, 2023

Description

Major rework of DHWSYSRES and associated DHWSYS energy balance error detection.

  • More granular accounting of components of energy additions and losses to DHWSYS water.
  • Correction of pre-existing accounting bugs so energy balance is correctly formulated.
  • Runtime check and warning messages re DHWSYS energy balance errors.
  • Update of several DHW tests to include DHWSYSRES reports and improve coverage by addition of additional DHWSYS components.
  • Minor results changes expected due to reorganized code. No fundamental calculation algorithm changes.
  • Also fixed unrelated reporting bug that caused year total report row to be interleaved with month rows for e.g. METER reports with rpFreq=MONTH.

@chipbarnaby chipbarnaby changed the title Dhwbal DHWSYSRES rework and DHWSYS energy balance diagnostics May 18, 2023
@chipbarnaby chipbarnaby merged commit ccf6a48 into main May 18, 2023
@chipbarnaby chipbarnaby deleted the dhwbal branch May 18, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants