Record info internals: add struct SFIR member to identify fields requiring special case (non-bitwise) copy #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nealkruis
requested changes
Jun 12, 2023
Contributor
nealkruis
left a comment
nealkruis
left a comment
There was a problem hiding this comment.
PR title needs to be more descriptive and #if 0 code should be removed or commented better.
chipbarnaby
changed the title
nealkruis
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Internal change to struct SFIR. Added member fi_nxsc to allow a linked list of fields requiring non-bitwise processing during e.g copy. Altered RCDEF to populate fi_nxsc.
Motivation: provides support for generalized record::Copy(). This will allow elimination of semi-redundant record::Copy() and record::CopyFrom(). Plus eliminate many overrides of record virtuals.
Also added fi_ prefix to SFIR members.
No results changes expected.