Alternative string pointers (preliminary support for 64-bit) #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nealkruis
approved these changes
Jul 18, 2023
| /test/error_handling/*.spl | ||
| # !/test/*.exe see below | ||
|
|
||
| test2/ |
There was a problem hiding this comment.
This is strange, but mostly harmless.
Comment on lines
-926
to
-929
| // Set up weather file, TDV file, and DESCONDs | ||
| // Do each phase, allowing file or location changes. | ||
| // Messages errors. | ||
| CSE_EF( Top.tp_WthrInit() ) // also uses Top .tp_wfName, .skyModel [,.isDT] |
There was a problem hiding this comment.
Was this partly redundant?
There was a problem hiding this comment.
Yes. The function actually did not do what the comments said.
| case DTFLOAT: | ||
| floatCase: // number-choice comes here (from default) if does not contain choice | ||
|
|
||
| #if 1 |
There was a problem hiding this comment.
Can we remove the #if 1?
There was a problem hiding this comment.
Will look after merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To support a 64 bit implementation, the PR replaces char* pointers within records with 4 byte handles that allow access to strings. This allows 4 byte NANDLE values to be used to link to string expressions. On 64 bit systems, char* pointers are 8 bytes while floats are 4 bytes which would complicate the NANDLE/expression scheme.
A new test "commands.cse" has been added that exercises some tricky cases related to object manipulation and string expressions.
No changes in input or other function. All tests pass with small-if-any results changes.