Skip to content

Conversation

@chipbarnaby
Copy link
Contributor

@chipbarnaby chipbarnaby commented Jul 26, 2023

Description

  1. Strengthen test cases that exercise choicn choice types (that can be given either numeric values or choices).
  • The code handling these is tricky and may have been impacted during alt-string-ptr conversion.
  • Test DHW_DR.cse has been added that used DHW demand response controls (using choicn inputs).
  • Test 3ZAirNetAH.cse replaces 3ZoneAirNet.cse and 3ZoneAirNetCSW.cse (which were identical except for weather file). AIRHANDLER is enabled in 3ZAirNetAH.cse and it uses an expression that changes supply air temp between fixed (numeric value) and RA (return air temp control).
  1. Fixed 2 bugs discovered by running regression tests with debug build.
  • Incorrect conversion of Top.dateStr to CULSTR (an missing NULL in strtcat() call)
  • Missing overrides for DHWSOLARSYS::Copy and DHWSOLARSYS::CopyFrom() caused incorrect handling of vector in HPWHLINK.
  1. Some unused files are deleted.

@chipbarnaby chipbarnaby marked this pull request as draft July 26, 2023 15:00
@chipbarnaby chipbarnaby marked this pull request as ready for review July 27, 2023 15:03
@nealkruis nealkruis changed the title Test choicn Improve testing of choicn types Jul 27, 2023
@nealkruis nealkruis merged commit 17806bf into main Jul 27, 2023
@nealkruis nealkruis deleted the test-choicn branch July 27, 2023 17:58
@chipbarnaby chipbarnaby restored the test-choicn branch July 27, 2023 18:16
@chipbarnaby chipbarnaby deleted the test-choicn branch July 27, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants