Fix pressure for AIRNETEXT with overridden exterior conditions #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relief-vent scheme (AIRNETEXT with overridden exterior conditions produced bad results.
With this PR, AIRNETEXT exterior pressure is now computed with ambient (outdoor) air density. This can be thought of as meaning the relief vents are connect to a zone with outdoor pressure -- that is, a zone with a large vent area to ambient.
Additional changes
One regression test uses overridden exterior conditions. Associated reference result file updated.
No documentation changes.