Skip to content

Conversation

@nealkruis
Copy link
Contributor

No description provided.

@nealkruis nealkruis self-assigned this Dec 31, 2018
@nealkruis
Copy link
Contributor Author

@chipbarnaby if we remove the PVWatts DLL, we can do it on this branch.

src/CNRECS.DEF Outdated
*r FLOAT pv_tGrndRatio // ratio of ground-cell temperature diff. to air-cell temperature diff.
*r *hide FLOAT_GEZ pv_thermCap // thermal capacitance of the array, J/kg-m2
*h *e FLOAT pv_poaPv // previous timestep plane of array incidence, Btu/h-ft2
*h *e FLOAT pv_radIPv // previous timestep total radiation incident on array, Btu/h-ft2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Pv suffix (for previous value I assume?) is unfortunate given that everything is pv here. Elsewhere, we use Ls (last step) for this.

Also, is the timestep hour or subhour?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I think I borrowed the suffix convention from here. I'm fine changing it. Currently PV is calculated hourly, but it could change to subhour down the road I suppose.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at other contexts ... sometimes PvHr (for hourly values), sometime ls for subhour. Not particularly consistent. So perhaps avoiding Pv here would be helpful? Not a big deal obviously.

Copy link
Contributor

@chipbarnaby chipbarnaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one comment about use of Pv suffix ... did that come through?

}
// round to nearest thousandth to minimize pixel precision
// errors for unshaded surfaces and differences among GPUs
roundNearest(fBeam, 0.001f);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chipbarnaby thoughts on this? I think it will eliminate hardware differences.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds OK, negligible results impact and could help with compare noise.

@nealkruis nealkruis merged commit 3daac95 into master Dec 31, 2018
@nealkruis nealkruis deleted the pv-power-electronics branch December 31, 2018 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants