-
Notifications
You must be signed in to change notification settings - Fork 8
Add ability to model PV Power Electronics #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@chipbarnaby if we remove the PVWatts DLL, we can do it on this branch. |
src/CNRECS.DEF
Outdated
| *r FLOAT pv_tGrndRatio // ratio of ground-cell temperature diff. to air-cell temperature diff. | ||
| *r *hide FLOAT_GEZ pv_thermCap // thermal capacitance of the array, J/kg-m2 | ||
| *h *e FLOAT pv_poaPv // previous timestep plane of array incidence, Btu/h-ft2 | ||
| *h *e FLOAT pv_radIPv // previous timestep total radiation incident on array, Btu/h-ft2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Pv suffix (for previous value I assume?) is unfortunate given that everything is pv here. Elsewhere, we use Ls (last step) for this.
Also, is the timestep hour or subhour?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I think I borrowed the suffix convention from here. I'm fine changing it. Currently PV is calculated hourly, but it could change to subhour down the road I suppose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at other contexts ... sometimes PvHr (for hourly values), sometime ls for subhour. Not particularly consistent. So perhaps avoiding Pv here would be helpful? Not a big deal obviously.
chipbarnaby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one comment about use of Pv suffix ... did that come through?
| } | ||
| // round to nearest thousandth to minimize pixel precision | ||
| // errors for unshaded surfaces and differences among GPUs | ||
| roundNearest(fBeam, 0.001f); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chipbarnaby thoughts on this? I think it will eliminate hardware differences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds OK, negligible results impact and could help with compare noise.
No description provided.