Change HPWH storage tank setpoint; enable HPWH tank-temp initialization

[spahrenk]

Description

• The HPWH preset storage-tank setpoint temperature has been changed to 127 degF. This changed the cse report for test dhw_solar, which uses this particular HPWH preset.
• This feature was designed to facilitate HPWH model development. Previously, HPWH initialized the tank to the setpoint temperature, rather than a laboratory value. HPWH functionality was added that allows initializing the tank to a temperature other than the setpoint. cse does not depend on this mechanism to change tank temperatures.

Author Progress Checklist:

• Open draft pull request
  • Make title clearly understandable in a standalone change log context
  • Assign yourself the issue
  • Add at least one label (enhancement, bug, or maintenance)
  • Link the issue(s) addressed by this PR (under "Development" in the sidebar menu)
• Make code changes (if you haven't already)
• Self-review of code
  • My code follows the style guidelines of this project
  • I have added comments to my code, particularly in hard-to-understand areas
  • I have only committed the necessary changes for this fix or feature
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have ensured that my fix is effective or that my feature works as intended by:
    • exercising the code changes in the test framework, and/or
    • manually verifying the changes (as explained in the the pull request description above)
  • My changes pass all local tests
  • My changes successfully passes CI checks
  • Add any unit test for proof and documentation.
  • Merge in main branch and address resulting conflicts and/or test failures.
• Move pull request out of draft mode and assign reviewers
• [] Iterate with reviewers until all changes are approved
  • Make changes in response to reviewer comments
  • Merge in main branch and address resulting conflicts and/or test failures.
  • Re-request review in GitHub

Reviewer Checklist:

• Read the pull request description
• Perform a code review on GitHub
• Confirm all CI checks pass and there are no build warnings
• Pull, build, and run automated tests locally
• Perform manual tests of the fix or feature locally
• Add any review comments, if applicable
• Submit review in GitHub as either
  • Request changes, or
  • Approve
• Iterate with author until all changes are approved

[nealkruis]

Trying to make sense of the change in results. Overall, the differences don't seem huge, but bigger than I'd expect. That doesn't mean there is anything wrong, but the changes aren't intuitive:

The initial temperature was reduced, but we are now seeing higher temperatures in the tank well into the year (including some above the default max Heat Exchanger temperature of 180F--hence the warning).

After looking at the changes in HPWHsim, I wonder if it's related to the weird controls of the extra-heat heat source. I'll leave some ideas in that PR review.