Skip to content

Conversation

@spahrenk
Copy link
Contributor

@spahrenk spahrenk commented Dec 11, 2023

Description

-The data structure for handling extra heat was changed in HPWHsim. This changes the method by which cse-dhw_solar specifies the distribution of extra heat to HPWHsim. Previously, the values were specified in a std::vector of size 3 containing the bottom three of an implied twelve nodes. Now, the values are specified in a std::vector of size 4, where the first assigns power to the bottom 1/4 of the tank, with the rest zero.
-Note that the method for measuring the tank temperature has not been changed. Previously, both adding heat and measuring temperature referred to the same parameter hw_nQTXNodes.
-No cse tests are affected by these changes.

Author Progress Checklist:

  • Open draft pull request
    • Make title clearly understandable in a standalone change log context
    • Assign yourself the issue
    • Add at least one label (enhancement, bug, or maintenance)
    • Link the issue(s) addressed by this PR (under "Development" in the sidebar menu)
  • Make code changes (if you haven't already)
  • Self-review of code
    • My code follows the style guidelines of this project
    • I have added comments to my code, particularly in hard-to-understand areas
    • I have only committed the necessary changes for this fix or feature
    • I have made corresponding changes to the documentation
    • My changes generate no new warnings
    • I have ensured that my fix is effective or that my feature works as intended by:
      • exercising the code changes in the test framework, and/or
      • manually verifying the changes (as explained in the the pull request description above)
    • My changes pass all local tests
    • My changes successfully passes CI checks
    • Add any unit test for proof and documentation.
    • Merge in main branch and address resulting conflicts and/or test failures.
  • Move pull request out of draft mode and assign reviewers
  • [] Iterate with reviewers until all changes are approved
    • Make changes in response to reviewer comments
    • Merge in main branch and address resulting conflicts and/or test failures.
    • Re-request review in GitHub

Reviewer Checklist:

  • Read the pull request description
  • Perform a code review on GitHub
  • Confirm all CI checks pass and there are no build warnings
  • Pull, build, and run automated tests locally
  • Perform manual tests of the fix or feature locally
  • Add any review comments, if applicable
  • Submit review in GitHub as either
    • Request changes, or
    • Approve
  • Iterate with author until all changes are approved

@spahrenk spahrenk requested a review from nealkruis December 11, 2023 20:26
@spahrenk spahrenk self-assigned this Dec 11, 2023
@spahrenk spahrenk changed the title Change extra heat method hpwh Change method for specifying extra heat to HPWHsim Dec 11, 2023
@nealkruis
Copy link
Contributor

This branch needs main merged in.

Copy link
Contributor

@nealkruis nealkruis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge main and update HPWHsim module to point to the latest "master" branch.

@nealkruis nealkruis self-requested a review December 12, 2023 23:56
@nealkruis nealkruis merged commit 99c64c5 into main Dec 12, 2023
@nealkruis nealkruis deleted the change-extra-heat-method-hpwh branch December 12, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants