Change method for specifying extra heat to HPWHsim #451
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-The data structure for handling extra heat was changed in HPWHsim. This changes the method by which cse-dhw_solar specifies the distribution of extra heat to HPWHsim. Previously, the values were specified in a std::vector of size 3 containing the bottom three of an implied twelve nodes. Now, the values are specified in a std::vector of size 4, where the first assigns power to the bottom 1/4 of the tank, with the rest zero.
-Note that the method for measuring the tank temperature has not been changed. Previously, both adding heat and measuring temperature referred to the same parameter hw_nQTXNodes.
-No cse tests are affected by these changes.
Author Progress Checklist:
Reviewer Checklist: