Fix external heat energy balance hpwh

[spahrenk]

Description

• Applies HPWHsim branch fix-external-heat-energy-balance.
• A change from float to double of constants DENSITYWATER_kgperL, KWATER_WpermC, and CPWATER_kJperkgC was used to improve precision in HPWHsim, particularly in relation to energy balancing. These changes affected nine cse tests, listed below. Differences appear to be small (many -0's for example.)
  ashpPkgRoom
  dhwDU
  dhw_solar
  dhw_zone
  dhw_dr
  dhw_brwl
  dhwloop32U
  chdhw
  submeter

Author Progress Checklist:

• Open draft pull request
  • Make title clearly understandable in a standalone change log context
  • Assign yourself the issue
  • Add at least one label (enhancement, bug, or maintenance)
  • Link the issue(s) addressed by this PR (under "Development" in the sidebar menu)
• Make code changes (if you haven't already)
• Self-review of code
  • My code follows the style guidelines of this project
  • I have added comments to my code, particularly in hard-to-understand areas
  • I have only committed the necessary changes for this fix or feature
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have ensured that my fix is effective or that my feature works as intended by:
    • exercising the code changes in the test framework, and/or
    • manually verifying the changes (as explained in the the pull request description above)
  • My changes pass all local tests
  • My changes successfully passes CI checks
  • Add any unit test for proof and documentation.
  • Merge in main branch and address resulting conflicts and/or test failures.
• Move pull request out of draft mode and assign reviewers
• Iterate with reviewers until all changes are approved
  • Make changes in response to reviewer comments
  • Merge in main branch and address resulting conflicts and/or test failures.
  • Re-request review in GitHub

Reviewer Checklist:

• Read the pull request description
• Perform a code review on GitHub
• Confirm all CI checks pass and there are no build warnings
• Pull, build, and run automated tests locally
• Perform manual tests of the fix or feature locally
• Add any review comments, if applicable
• Submit review in GitHub as either
  • Request changes, or
  • Approve
• Iterate with author until all changes are approved

[nealkruis]

Nothing of concern here from my perspective! @chipbarnaby, do you want to have a quick look?

This can go in after the heat exchange branch (and this branch is updated accordingly).

[chipbarnaby]

Agree, looks good to me. Merge away.

…

On Tue, Jan 9, 2024 at 4:22 PM Neal Kruis ***@***.***> wrote: Nothing of concern here from my perspective! @chipbarnaby <https://github.com/chipbarnaby>, do you want to have a quick look? This can go in after the heat exchange branch (and this branch is updated accordingly). — Reply to this email directly, view it on GitHub <#458 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACWGW7D3NG3YHKVLNR4YNP3YNWYK5AVCNFSM6AAAAABBTXGEXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBTHAYTMMRZHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[nealkruis]

I just tagged v1.23.0 on HPWHsim. This branch should merge main and update the HPWHsim submodule one more time to point to the official HPWHsim release, then it can merge and we can tag a new version of CSE!

@spahrenk can you take care of the HPWHsim submodule, then I'll merge and tag a CSE release.