Skip to content

Conversation

@spahrenk
Copy link
Contributor

@spahrenk spahrenk commented Feb 12, 2024

Description

  • HPWHsim unit tests were converted to using googletest. In the process, the library name was changed to HPWHsim and the names of a few functions used by cse were changed.
  • Changed dhwloop32U.rep ref due to 0<->-0 differences.

Author Progress Checklist:

  • Open draft pull request
    • Make title clearly understandable in a standalone change log context
    • Assign yourself the issue
    • Add at least one label (enhancement, bug, or maintenance)
    • Link the issue(s) addressed by this PR (under "Development" in the sidebar menu)
  • Make code changes (if you haven't already)
  • Self-review of code
    • My code follows the style guidelines of this project
    • I have added comments to my code, particularly in hard-to-understand areas
    • I have only committed the necessary changes for this fix or feature
    • I have made corresponding changes to the documentation
    • My changes generate no new warnings
    • I have ensured that my fix is effective or that my feature works as intended by:
      • exercising the code changes in the test framework, and/or
      • manually verifying the changes (as explained in the the pull request description above)
    • My changes pass all local tests
    • My changes successfully passes CI checks
    • Add any unit test for proof and documentation.
    • Merge in main branch and address resulting conflicts and/or test failures.
  • Move pull request out of draft mode and assign reviewers
  • [] Iterate with reviewers until all changes are approved
    • Make changes in response to reviewer comments
    • Merge in main branch and address resulting conflicts and/or test failures.
    • Re-request review in GitHub

Reviewer Checklist:

  • Read the pull request description
  • Perform a code review on GitHub
  • Confirm all CI checks pass and there are no build warnings
  • Pull, build, and run automated tests locally
  • Perform manual tests of the fix or feature locally
  • Add any review comments, if applicable
  • Submit review in GitHub as either
    • Request changes, or
    • Approve
  • Iterate with author until all changes are approved

@spahrenk spahrenk requested a review from nealkruis February 12, 2024 18:34
@spahrenk spahrenk self-assigned this Feb 12, 2024
@nealkruis
Copy link
Contributor

Thanks, @spahrenk!

This is looking good and can drop in after we settle out some of the other open PRs.

@nealkruis
Copy link
Contributor

@chipbarnaby this PR is likely ready to drop in (after the corresponding HPWHsim branch is merged). It includes some minor API changes for HPWHsim (i.e., removes redundant naming redundancies).

@nealkruis
Copy link
Contributor

The corresponding HPWHsim PR has been merged into its main. @spahrenk can you:

  1. Merge CSE 'main` into this branch
  2. Update the HPWHsim submodule on this branch to point to its main?

Thanks!

@nealkruis nealkruis merged commit f0da7e9 into main Feb 26, 2024
@nealkruis nealkruis deleted the add-unit-tests-hpwh branch February 26, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants