Skip to content

Bug fix: prevent crash due to autosized DHWHEATER tank volume = 0 #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Bug fix: prevent crash due to autosized DHWHEATER tank volume = 0 #480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/dhwcalc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,7 +664,7 @@ RC DHWSIZER::wz_DeriveSize() // calc required heating and storage volume
// required volume (based on setpoint, not use temp)
// tank volume is derived from running volume in HPWHLINK::hw_DeriveVolFromVolRunning()
// (applies aquastat fraction etc.)
float volRunning = -qRunning / (waterRhoCp * (pWS->ws_tSetpointDes - pWS->ws_tInletDes));
float volRunning = max(10.f, -qRunning / (waterRhoCp * (pWS->ws_tSetpointDes - pWS->ws_tInletDes)));

pWS->ws_ApplySizingResults(heatingCapDes, heatingCapTopN, volRunning);

Expand Down Expand Up @@ -3415,7 +3415,7 @@ RC HPWHLINK::hw_DeriveVolFromVolRunning( // calc required volume from running v

// total volume req'd based on minimum run time (avoid short cycle)
// Determine vol of water heated in minimum compressor cycle.
// Usable volume below aquastat must be >= to
// Usable volume below aquastat must be >= to this vol
float runHrMin = hw_pHPWH->getCompressorMinRuntime( HPWH::UNITS_HR); // minimum compressor run time, hr
float volCycMin = heatingCap * runHrMin / (waterRhoCp * max(tempRise, 10.f));
float totVolCyc = volCycMin / (aquaFract - unuseableFract);
Expand Down