Revise zone "vent useful" logic #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CBECC generated runs containing zones w/o znTD failed with "znTD required" messages in cases where znTD should not be needed. For example, cases with HERV ventilation -- HERV air flow is not controlled by vent logic and the presence of HERV IAQ venting in itself should not cause a zone to determine that vent mode operation might be helpful.
Found that the logic used in the "vent useful" mechanism (in IZXRAT) was run during iz_beghour() and depended on info that was not available until subhour time. Moved it to iz_begsubhr().
CBECC file that brough up this issue now runs to completion.
Minor changes in a few regression results. Updated ref files for those.
No documentation changes.