Bug fix: ASHRAE clear sky model (used in DESCOND) #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipbarnaby
changed the title
nealkruis
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Debug-build messages reminded me of a long-standing test failure related to DESCOND derivation of ASHRAE clear sky tau parameters from noon irradiance. The test was showing a small mismatch in the taub result.
Investigation revealed a one char typo in the code ("-" instead of "+") in function ASHRAETauModel(). Corrected that and re-verified all expressions against the ASHRAE HOF chapter 14 text.
This code is used for generating design day weather for cooling autosizing that use DESCOND input.
Tightened the debug build test criteria since the match is now essentially perfect.
No changes in regression test results because no tests depend on this use.
Very small changes in equipment sizes in the case that initiated this fix.
No documentation changes.