Skip to content

Fix sky temperature calculation #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2019
Merged

Fix sky temperature calculation #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0d7107
Fix sky temperature calculation.
nealkruis Jan 23, 2019
9f0001e
Updated test ashptest2 to use EPW weather file.
chipbarnaby Jan 28, 2019
287fa0e
Test file changes overlooked in last commit
chipbarnaby Jan 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/WFPAK.CPP
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1085,7 +1085,7 @@ float CalcSkyTemp( // sky temp model
float e0 = .711 + (0.56f/100.f)*taDpC + (.73f/10000.f)*taDpC*taDpC
+ hrConst[ iHr] + .12f * (presAtm/29.53f - 1.f);

eSky = e0 + 0.467f*(1.f - e0)*cldCvr/10.f;
eSky = e0 + 0.784f*(1.f - e0)*cldCvr/10.f; // equation 76 from 2013 ACM
}
else
{ err( ABT, "CalcSkyTemp: Invalid skyModelLW=%d", skyModelLW);
Expand Down
2 changes: 1 addition & 1 deletion test/ASHPTest2.cse
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#define CD1 Jul 10
#define HD1 Dec 03
repHdrL = "12 P21 G20 TILE"
wfName = "CTZ12S13b.CSW"
wfname = "USA_CA_Sacramento.Exec.AP.724830_CTZ2010.epw"
ebTolHour = 0.001
ebTolDay = 0.001
ebTolMon = 0.001
Expand Down
Loading