Make TI 32 bit (eliminate 32767 record limit) #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
chipbarnaby
changed the title
nealkruis
requested changes
Sep 3, 2024
src/ancrec.h
Outdated
Comment on lines
462
to
470
| #if 0 | ||
| template <class T> void anc<T>::desRecs( TI _mn, TI _n) | ||
| // ?? why isn't basAnc::desRecs sufficient, 5-31-92? | ||
| { | ||
| if (ptr()) // if record memory is allocated | ||
| for (TI i = max(mn,_mn); i <= min(n,_n); i++) // loop allocated record spaces in range given by caller | ||
| desRec(i); // conditionally destroy record in space with record-deriv d'tor ~T. | ||
| } // anc<T>::desRecs | ||
| #endif |
src/ancrec.h
Outdated
|
|
||
| protected: | ||
| void desRecs( TI mn=0, TI n=32767); // ~ all records or range (as b4 freeing block) | ||
| // void desRecs( TI mn=0, TI n=32767); // ~ all records or range (as b4 freeing block) |
nealkruis
approved these changes
Sep 4, 2024
nealkruis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change TI from 16 bit (int16_t) to 32 bit (int32_t). This allows CSE to have more than 32767 records in a given RAT.
No results changes. No documentation changes.
Note: modified code does not detect / handle other memory limits. See issue 502.