Constrain recent performance maps; add 80-gal LG model #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nealkruis
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues with the performance maps of recently added Bradford White and LG models are tentatively resolved with these changes. Most HPWHsim model descriptions have defined their performance maps using polynomial expansions. Extrapolation of these polynomials generates unreasonable values (cop < 1, Pin < 0) in some conditions. The polynomial coefficients for these recently added models were adjusted to limit this occurrence.
An additional 80-gal LG model (LG_APHWC80) was added to HPWHsim and defined in cse.