Skip to content

Conversation

@chipbarnaby
Copy link
Contributor

@chipbarnaby chipbarnaby commented Aug 7, 2025

Description

SDK version 10.0.20348.0 has been removed as of Visual Studio 17.14.11.

Per release notes --

The following Windows SDK versions have been removed from the Visual Studio 2022 installer: 10.0.18362.0, 10.0.20348.0 and 10.0.22000.0. If your project targets any of these SDKs you may encounter a build error such as: The Windows SDK version 10.0.22000.0 was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution". To resolve this, we recommend retargeting your project to 10.0.26100.0, or an earlier supported version if necessary. For a complete list of supported SDK versions please visit: https://developer.microsoft.com/windows/downloads/sdk-archive/.

This PR updates the SDK used for CSE to 10.0.26100.0 as directed.

No results changes.

@chipbarnaby chipbarnaby marked this pull request as draft August 7, 2025 17:55
@chipbarnaby chipbarnaby marked this pull request as ready for review August 13, 2025 20:34
@chipbarnaby chipbarnaby requested a review from nealkruis August 13, 2025 20:34
Copy link
Contributor

@nealkruis nealkruis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add clarifying comment.

@nealkruis
Copy link
Contributor

@chipbarnaby @tanaya-mankad this is fine for now, but eventually we want to to update the toolset version too. The build script eventually needs to document the considerations better.

@tanaya-mankad
Copy link
Contributor

@nealkruis @chipbarnaby I've been exploring this problem for atheneum-forge. The toolset stuff is a morass, I can explain it sometime, but the SDK versioning I think I can add CMake management for.

@nealkruis nealkruis merged commit 5c600f7 into main Aug 15, 2025
4 checks passed
@nealkruis nealkruis deleted the update-sdk branch August 15, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants