Skip to content

Remove upper limit on COP in performance maps. #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2025
Merged

Remove upper limit on COP in performance maps. #572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
840dd7f
Remove upper limit on COP in performance maps.
nealkruis Sep 12, 2025
3c01f14
Fix typo in documentation.
nealkruis Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/src/records/rsys.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ ACPMFURNACE, Compressor-based cooling modeled per PERFORMANCEMAP specified in rs
ACRESISTANCE, Compressor-based cooling and electric ('strip') heating. Cooling performance based on SEER and EER. Primary heating input energy is accumulated to end use HTG of meter rsElecMtr.
ACPMRESISTANCE, Cooling based on PERFORMANCEMAP specified in rsPerfMapClg. Primary heating input energy is accumulated to end use HTG of meter rsElecMtr.
ASHP, Air-source heat pump (compressor-based heating and cooling). Primary (compressor) heating input energy is accumulated to end use HTG of meter rsElecMtr. Auxiliary and defrost heating input energy is accumulated to end use HPBU of meter rsElecMtr or meter rsFuelMtr (depending on rsTypeAuxH).
ASHPKGROOM, Packaged room air-source heat pump.
ASHPPKGROOM, Packaged room air-source heat pump.
ASHPHYDRONIC, Air-to-water heat pump with hydronic distribution. Compressor performance is approximated using the air-to-air model with adjusted efficiencies.
ASHPPM, Air-to-air heat pump modeled per PERFORMANCMAPs specified via rsPerfMapHtg and rsPerfMapClg.
WSHP, Water-to-air heat pump.
Expand Down
2 changes: 1 addition & 1 deletion src/curvemap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ RC PERFORMANCEMAP::pm_SetupBtwxt( // input -> Btwxt conversion
rc |= pm_LUCheckAndMakeVector(1, pLUCap, vCapRat, LUSize);
PMLOOKUPDATA* pLUCOP;
std::vector< double> vCOP;
rc |= pm_LUCheckAndMakeVector(2, pLUCOP, vCOP, LUSize, 0.1, 20.);
rc |= pm_LUCheckAndMakeVector(2, pLUCOP, vCOP, LUSize, 0.1);

if (rc)
return rc;
Expand Down