Performance map based RSYS multizone bug fix #578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nealkruis
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A user reported anomalous results for a run that included 2 conditioned zones served by a single RSYS.
Investigation revealed logic error for the case when one (or both?) zones request no conditioning. That is, when one zone needs heating and the other needs nothing or cooling. Simultaneous heating and cooling are not supported. The first zone request sets the RSYS mode (heating or cooling). Subsequent requests that do not match the established mode are ignored and the requesting zone temperature floats.
This PR fixes the multizone logic.
Added a 2 zone / 1 RSYS test case.
No regression changes except for the new test.
No documentation changes.