Skip to content

Frontend/Dep major version updates#1773

Open
jsandoval81 wants to merge 1 commit into
csg-org:mainfrom
InspiringApps:frontend/dep-major-versions-2026-07-22
Open

Frontend/Dep major version updates#1773
jsandoval81 wants to merge 1 commit into
csg-org:mainfrom
InspiringApps:frontend/dep-major-versions-2026-07-22

Conversation

@jsandoval81

@jsandoval81 jsandoval81 commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Requirements List

  • yarn install --ignore-engines

Description List

  • Updated dependency major versions for:
    • vue-i18n
    • babel-loader
    • cypress
    • express
    • less-loader
    • stylelint
    • stylelint-webpack-plugin
  • Updated vue-i18n config to be forward compatible with planned changes / deprecations in upcoming v12

Testing List

  • yarn test:unit:all should run without errors or warnings
  • yarn serve should run without errors or warnings
  • yarn build should run without errors or warnings
  • Code review
  • Smoke test UI

Closes #1519
Closes #1522
Closes #1525
Closes #1648
Closes #1651
Closes #1652
Closes #1653
Closes #1677

Summary by CodeRabbit

  • Refactor

    • Updated internationalization configuration for modern locale handling and global translation access.
    • Improved translation behavior by disabling HTML message warnings.
  • Tests

    • Updated test setup to use the current reactive locale and fallback-locale configuration.
    • Simplified component test mocks while preserving API test support.
  • Chores

    • Upgraded translation, build, testing, server, and style tooling packages.

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Updated frontend dependencies, migrated Vue I18n to its v11 configuration, and aligned model and component test setup with reactive locale fields and global i18n injection.

Changes

Frontend dependency and i18n migration

Layer / File(s) Summary
Frontend dependency updates
webroot/package.json
Upgraded Vue I18n and frontend tooling dependencies, and removed the Vue I18n unplugin dependency.
Vue I18n configuration
webroot/src/i18n.ts
Disabled legacy mode, enabled global injection, and replaced the HTML message warning option.
Test i18n setup migration
webroot/src/models/*/*.model.spec.ts, webroot/tests/helpers/setup.ts
Updated locale and fallback-locale assignments to reactive .value fields and removed redundant $t and $i18n mocks from mount helpers.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: jlkravitz

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR updates most requested deps, but it removes @intlify/unplugin-vue-i18n instead of bumping it to 11.2.3 for #1648. Restore @intlify/unplugin-vue-i18n at 11.2.3 with matching lockfile updates, or explicitly document that #1648 was superseded by its removal.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and clearly describes the main change: frontend dependency major version updates.
Description check ✅ Passed The description matches the template with requirements, change summary, testing, and closing issues.
Out of Scope Changes check ✅ Passed The diff appears focused on the requested dependency upgrades and i18n test/setup changes, with no obvious unrelated edits.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.3.8)
webroot/package.json

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@webroot/src/i18n.ts`:
- Line 11: Update the i18n configuration containing warnHtmlMessage to enable
the separate escapeParameter option, ensuring interpolated values in HTML
messages are escaped while preserving the existing warning configuration.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cf87c9a9-b624-4ac8-ab71-a4c951a8d6b9

📥 Commits

Reviewing files that changed from the base of the PR and between f0d0106 and d7dd7f0.

⛔ Files ignored due to path filters (1)
  • webroot/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (10)
  • webroot/package.json
  • webroot/src/i18n.ts
  • webroot/src/models/AdverseAction/AdverseAction.model.spec.ts
  • webroot/src/models/Compact/Compact.model.spec.ts
  • webroot/src/models/Investigation/Investigation.model.spec.ts
  • webroot/src/models/License/License.model.spec.ts
  • webroot/src/models/LicenseHistoryItem/LicenseHistoryItem.model.spec.ts
  • webroot/src/models/PrivilegeAttestation/PrivilegeAttestation.model.spec.ts
  • webroot/src/models/PrivilegePurchaseOption/PrivilegePurchaseOption.model.spec.ts
  • webroot/tests/helpers/setup.ts

Comment thread webroot/src/i18n.ts
@jsandoval81
jsandoval81 requested a review from rmolinares July 23, 2026 15:37
@jsandoval81
jsandoval81 requested a review from jlkravitz July 23, 2026 16:16
@jsandoval81

Copy link
Copy Markdown
Collaborator Author

@jlkravitz This is ready for review.

@jlkravitz jlkravitz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isabeleliassen Good to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants