Frontend/Dep major version updates#1773
Conversation
📝 WalkthroughWalkthroughUpdated frontend dependencies, migrated Vue I18n to its v11 configuration, and aligned model and component test setup with reactive locale fields and global i18n injection. ChangesFrontend dependency and i18n migration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.8)webroot/package.jsonTraceback (most recent call last): Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@webroot/src/i18n.ts`:
- Line 11: Update the i18n configuration containing warnHtmlMessage to enable
the separate escapeParameter option, ensuring interpolated values in HTML
messages are escaped while preserving the existing warning configuration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: cf87c9a9-b624-4ac8-ab71-a4c951a8d6b9
⛔ Files ignored due to path filters (1)
webroot/yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (10)
webroot/package.jsonwebroot/src/i18n.tswebroot/src/models/AdverseAction/AdverseAction.model.spec.tswebroot/src/models/Compact/Compact.model.spec.tswebroot/src/models/Investigation/Investigation.model.spec.tswebroot/src/models/License/License.model.spec.tswebroot/src/models/LicenseHistoryItem/LicenseHistoryItem.model.spec.tswebroot/src/models/PrivilegeAttestation/PrivilegeAttestation.model.spec.tswebroot/src/models/PrivilegePurchaseOption/PrivilegePurchaseOption.model.spec.tswebroot/tests/helpers/setup.ts
|
@jlkravitz This is ready for review. |
jlkravitz
left a comment
There was a problem hiding this comment.
@isabeleliassen Good to merge!
Requirements List
yarn install --ignore-enginesDescription List
vue-i18nbabel-loadercypressexpressless-loaderstylelintstylelint-webpack-pluginTesting List
yarn test:unit:allshould run without errors or warningsyarn serveshould run without errors or warningsyarn buildshould run without errors or warningsCloses #1519
Closes #1522
Closes #1525
Closes #1648
Closes #1651
Closes #1652
Closes #1653
Closes #1677
Summary by CodeRabbit
Refactor
Tests
Chores