Frontend/social work npdb categories - #1807
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe PR adds app-mode-specific discipline allowlists, expands Social Work NPDB categories, enables Social Work NPDB multi-select, adds English and Spanish translations, and updates the dashboard footer help link. ChangesEncumbrance and dashboard updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Im getting the same auth mocking issue here I think: |
ChiefStief
left a comment
There was a problem hiding this comment.
Looks good!
Just have the two comments.
|
|
||
| options = options.filter((option) => !excludeList.includes(option.value)); | ||
| if (isAppModeJcc) { | ||
| includeList.push('fine'); |
There was a problem hiding this comment.
This list looks the same as the isAppModeSocialWork, I think an argument could be made that that is happenstance and likely to change so using one list here is not worth it.
Im curious about the decision to do serial pushes rather than initializing a list and then concatenating them. Is that just so that we dont have an essentially unused variable in that list?
Generally, I feel like these should maybe be defined in some higher level config and then referenced here and in the privilege card rather than long listing them in both places? It feels like this is data to some extent rather than display logic based on that data.
Requirements List
Description List
Testing List
yarn test:unit:allshould run without errors or warningsyarn serveshould run without errors or warningsyarn buildshould run without errors or warningshttps://compactconnect.org/?page_id=399Closes #1759
Closes #1804
Summary by CodeRabbit
Enhancements
Updates