Skip to content

Frontend/social work npdb categories - #1807

Open
jsandoval81 wants to merge 1 commit into
csg-org:mainfrom
InspiringApps:frontend/sw-npdb-categories
Open

Frontend/social work npdb categories#1807
jsandoval81 wants to merge 1 commit into
csg-org:mainfrom
InspiringApps:frontend/sw-npdb-categories

Conversation

@jsandoval81

@jsandoval81 jsandoval81 commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Requirements List

  • None

Description List

  • Updated the NPDB categories for Social Work
  • Cleaned up the encumber list structure in the License & Privilege card components
  • Updated the Help Center link on the public dashboard (Update Help Center link #1804)

Testing List

  • yarn test:unit:all should run without errors or warnings
  • yarn serve should run without errors or warnings
  • yarn build should run without errors or warnings
  • Code review
  • Confirm the public dashboard Help Center link now points to https://compactconnect.org/?page_id=399
  • Login as staff admin and confirm the License & Privilege encumber modals have the expected values in the action & categories lists
    • JCC compacts & Social Work should also have the NPDB categories list as a multi-select. Cosmetology should still be a single select.

Closes #1759
Closes #1804

Summary by CodeRabbit

  • Enhancements

    • Updated license and privilege discipline options based on application mode.
    • Added expanded NPDB category selections for JCC and Social Work, including multi-select support.
    • Added English and Spanish translations for new NPDB categories.
  • Updates

    • Updated the public dashboard footer link to the Compact Connect website.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: be60e57f-ab1c-4ec4-9fa9-4de7629023c7

📥 Commits

Reviewing files that changed from the base of the PR and between 95f69e8 and 2bec0c4.

📒 Files selected for processing (5)
  • webroot/src/components/LicenseCard/LicenseCard.ts
  • webroot/src/components/PrivilegeCard/PrivilegeCard.ts
  • webroot/src/locales/en.json
  • webroot/src/locales/es.json
  • webroot/src/pages/PublicDashboard/PublicDashboard.vue

📝 Walkthrough

Walkthrough

The PR adds app-mode-specific discipline allowlists, expands Social Work NPDB categories, enables Social Work NPDB multi-select, adds English and Spanish translations, and updates the dashboard footer help link.

Changes

Encumbrance and dashboard updates

Layer / File(s) Summary
Mode-specific discipline options
webroot/src/components/LicenseCard/LicenseCard.ts, webroot/src/components/PrivilegeCard/PrivilegeCard.ts
License and privilege cards now filter discipline options by app mode while retaining blank options.
Social Work NPDB options
webroot/src/components/LicenseCard/LicenseCard.ts, webroot/src/components/PrivilegeCard/PrivilegeCard.ts, webroot/src/locales/en.json, webroot/src/locales/es.json
Social Work uses expanded NPDB categories and multi-select input. English and Spanish translations include the added categories.
Dashboard help link
webroot/src/pages/PublicDashboard/PublicDashboard.vue
The footer help link now points to the Compact Connect website.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested reviewers: chiefstief, landonshumway-ia

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the primary Social Work NPDB category changes.
Description check ✅ Passed The description includes the required sections, summarizes the changes, and lists relevant testing and verification steps.
Linked Issues check ✅ Passed The changes implement the Social Work encumbrance updates and replace the Help Center link as required by [#1759] and [#1804].
Out of Scope Changes check ✅ Passed The locale updates and License and Privilege card restructuring support the linked objectives, with no unrelated code changes identified.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jsandoval81
jsandoval81 requested review from ChiefStief and removed request for ChiefStief August 4, 2026 20:55
@ChiefStief

Copy link
Copy Markdown
Collaborator

Im getting the same auth mocking issue here I think:

Error: AggregateError
    at Object.dispatchError (/Users/danastiefel/sites/inspiringapps/JCC-CompactConnect/webroot/node_modules/jsdom/lib/jsdom/living/xhr/xhr-utils.js:63:19)
    at Request.<anonymous> (/Users/danastiefel/sites/inspiringapps/JCC-CompactConnect/webroot/node_modules/jsdom/lib/jsdom/living/xhr/XMLHttpRequest-impl.js:655:18)
    at Request.emit (node:events:520:35)
    at ClientRequest.<anonymous> (/Users/danastiefel/sites/inspiringapps/JCC-CompactConnect/webroot/node_modules/jsdom/lib/jsdom/living/helpers/http-request.js:121:14)
    at ClientRequest.emit (node:events:508:28)
    at emitErrorEvent (node:_http_client:108:11)
    at Socket.socketErrorListener (node:_http_client:575:5)
    at Socket.emit (node:events:508:28)
    at emitErrorNT (node:internal/streams/destroy:170:8)
    at emitErrorCloseNT (node:internal/streams/destroy:129:3)
    at processTicksAndRejections (node:internal/process/task_queues:89:21)
    ```

@ChiefStief ChiefStief left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Just have the two comments.


options = options.filter((option) => !excludeList.includes(option.value));
if (isAppModeJcc) {
includeList.push('fine');

@ChiefStief ChiefStief Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list looks the same as the isAppModeSocialWork, I think an argument could be made that that is happenstance and likely to change so using one list here is not worth it.

Im curious about the decision to do serial pushes rather than initializing a list and then concatenating them. Is that just so that we dont have an essentially unused variable in that list?

Generally, I feel like these should maybe be defined in some higher level config and then referenced here and in the privilege card rather than long listing them in both places? It feels like this is data to some extent rather than display logic based on that data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Help Center link SW - update encumbrance categories

2 participants