Chore/remove mock api resources - part 1#337
Closed
landonshumway-ia wants to merge 24 commits intocsg-org:developmentfrom
Closed
Chore/remove mock api resources - part 1#337landonshumway-ia wants to merge 24 commits intocsg-org:developmentfrom
landonshumway-ia wants to merge 24 commits intocsg-org:developmentfrom
Conversation
landonshumway-ia
force-pushed
the
chore/remove-mock-api
branch
from
537d234 to
a458071
Compare
To reduce config file duplication
This will allow us to track the history of license records for a licensee
These are now managed in the common directory, so we can remove these.
This dependency is needed to work with other timezones
We have the requirement to resolve whether privileges and licenses are expired by checking the date in the eastern time zone. We expect this to change, so we are making it a configuration value to reference everywhere we need to resolve expiration dates.
We are splitting the concept of license status into two terms. The first is the status that is uploaded by the jurisdiction, which we are tracking as the 'jurisdictionStatus'. The second is the 'status' that is actually used by the system to determine eligibility for a user to purchase privileges. This adds the new 'jurisdictionStatus' field
Now that we are calculating the status based off of the expiration date and the jurisdictionStatus, we do not need to store the 'status' field in the DB. This ensures we are stripping the status from the record that is written to the table.
This was causing deployment issues with our lambdas that rely on the Authorize.net SDK The 3.13 runtime was just released this week, so the dependency mismatch will likely be resolved in the next couple of months after the runtime has had time to stabilized
landonshumway-ia
force-pushed
the
chore/remove-mock-api
branch
from
a458071 to
2519f66
Compare
CDK has a limitation where if you attempt to remove all references to a resource from another stack, CDK will attempt to remove the export for that resource, which then fails because it sees there is still an external dependency on that resource, creating a 'deadly embrace' See aws/aws-cdk#12778. The workaround for this is to set dummy export values to trick CDK into keeping the unused exports around until you've deployed your updates to the dependent stack.
landonshumway-ia
force-pushed
the
chore/remove-mock-api
branch
from
9f286f0 to
38f8cea
Compare
Collaborator
Author
|
Moved relevant commits into #344 to address merge conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These mock resources were put in place during the initial POC of the project. We have since moved onto actual API endpoints, so this dead code can be removed from the project.
This must be done in two phases to deal with cross stack dependencies in CloudFormation. This PR is part one, removing
the resources from the API stack. Once this change has been deployed through ALL environments, the second phase will be implemented to remove all the mock S3 resources from the Persistent stack.
Requirements List
Description List
/v0endpoints from API/mockendpoints from APIlicense-datalambda packagedelete-objectslambda packageTesting List
yarn test:unit:allshould run without errors or warningsyarn serveshould run without errors or warningsyarn buildshould run without errors or warningsbackend/compact-connect/tests/unit/test_api.pyCloses #110