Chore/remove api mocks - part 1#344
Merged
isabeleliassen merged 6 commits intocsg-org:developmentfrom Dec 2, 2024
Merged
Conversation
landonshumway-ia
force-pushed
the
chore/remove-api-mocks
branch
from
86ceca7 to
0f501ca
Compare
jusdino
approved these changes
Nov 22, 2024
Contributor
jusdino
left a comment
jusdino
left a comment
There was a problem hiding this comment.
Thanks for cleaning house!
Collaborator
Author
|
@jlkravitz This is ready for CSG review. Thanks. |
jlkravitz
previously approved these changes
Nov 26, 2024
Collaborator
jlkravitz
left a comment
jlkravitz
left a comment
There was a problem hiding this comment.
@isabeleliassen Good to merge!
isabeleliassen
previously approved these changes
Nov 26, 2024
This was causing deployment issues with our lambdas that rely on the Authorize.net SDK The 3.13 runtime was just released this week, so the dependency mismatch will likely be resolved in the next couple of months after the runtime has had time to stabilized
CDK has a limitation where if you attempt to remove all references to a resource from another stack, CDK will attempt to remove the export for that resource, which then fails because it sees there is still an external dependency on that resource, creating a 'deadly embrace' See aws/aws-cdk#12778. The workaround for this is to set dummy export values to trick CDK into keeping the unused exports around until you've deployed your updates to the dependent stack.
landonshumway-ia
dismissed stale reviews from isabeleliassen and jlkravitz
via
023735f
landonshumway-ia
force-pushed
the
chore/remove-api-mocks
branch
from
0f501ca to
023735f
Compare
isabeleliassen
approved these changes
Dec 2, 2024
jlkravitz
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These mock resources were put in place during the initial POC of the project. We have since moved onto actual API endpoints, so this dead code can be removed from the project.
This must be done in two phases to deal with cross stack dependencies in CloudFormation. This PR is part one, removing
the resources from the API stack. Once this change has been deployed through ALL environments, the second phase will be implemented to remove all the mock S3 resources from the Persistent stack.
Requirements List
Description List
/v0endpoints from API/mockendpoints from APIlicense-datalambda packagedelete-objectslambda packageTesting List
yarn test:unit:allshould run without errors or warningsyarn serveshould run without errors or warningsyarn buildshould run without errors or warningsbackend/compact-connect/tests/unit/test_api.pyCloses #110