feat(release-image): refuse a release when every image is already released - #66
Merged
Merged
Conversation
…eased A failed or unfinished build leaves the source tag on the previous release's digest, and the commit walk accepts that by construction (the parent commit is in branch history) — VirtualWindow v1.19.0 and v1.19.1 both re-tagged v1.18.1 this way (VirtualWindow#212). Pre-pass every image before any tag is written: if all of them already carry a release tag, stop with the version still free. One unchanged image among several stays allowed for path-filtered builds. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NWi7EZhJ5h4aNfBk3EoGDd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed or unfinished build leaves
:lateston the previous release's digest, andverify-source-commitaccepts that by construction — the parent commit is in branch history. VirtualWindow v1.19.0 and v1.19.1 both re-tagged the v1.18.1 image this way today (cshuttle/VirtualWindow#212).New pre-pass in the promote step, before any
crane tag: if every image's source digest already carries avX.Y.Ztag, fail with the version still free. One unchanged image among several stays allowed — a path-filtered build may legitimately have had nothing to rebuild (VirtualWindow's SPA vs config images).Checked locally with a fake
crane: all-stale → exit 1, zero tags written; one-fresh → both images tagged. Minor bump (new behaviour, no input change) → v1.9.0.🤖 Generated with Claude Code
https://claude.ai/code/session_01NWi7EZhJ5h4aNfBk3EoGDd