Merged
Conversation
rorywalsh
approved these changes
Sep 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An issue, reported by @rorywalsh, arose with the recently-introduced backwards compatibility code (#2261) where any global variables starting with an implicit type letter would be redefined as an (implicit-type) local when assigned locally. This was because the new code was applying the rule to all, when it should have selected only the global readonly vars added by the compiler (opcode and instrument names). This PR fixes the problem. Implicit globals always start with 'g' and none of the shadowing/redefinition rules are relevant in relation to them.