Skip to content

sequ overload with start point#2336

Merged
rorywalsh merged 1 commit intodevelopfrom
feature/sequ
Oct 30, 2025
Merged

sequ overload with start point#2336
rorywalsh merged 1 commit intodevelopfrom
feature/sequ

Conversation

@vlazzarini
Copy link
Member

This PR introduces a new version of sequ with a start point

kres = sequ(kstart, irhythm[], iinstr[], idata[], kbpm, klen [, kmode] [, kstep] \
            [, kreset] [, kverbose])
kres = sequ(kstart, irhythm[], iinstr[], idata[][], kbpm, klen [, kmode] [, kstep] \
            [, kreset] [, kverbose])

closes #2200

@vlazzarini vlazzarini requested a review from rorywalsh October 26, 2025 20:06
@vlazzarini
Copy link
Member Author

man page edit will follow PR merging.

@rorywalsh
Copy link
Contributor

I'm just wondering if this shouldn't be added as a new sequ2 opcode rather than overloading the existing one?

@vlazzarini
Copy link
Member Author

I prefer not to proliferate the number of opcodes, since now we have the overloading mechanism in place.

@rorywalsh
Copy link
Contributor

My first thought was a version 2 (which I have never liked), simply because that falls in line with how things have been done in the past and for better or worse has been a pretty consistant approach.

@rorywalsh rorywalsh merged commit d4388df into develop Oct 30, 2025
20 checks passed
@vlazzarini
Copy link
Member Author

I see, but we did not have a consistent overloading mechanism back then, now we do, so I thought we may as well promote it.

@rorywalsh
Copy link
Contributor

I wonder if we might now go back and overload all those other version 2 opcodes, marking them as deprecated. There was also talk of moving toward a consistent naming pattern for all opcodes. This is probably part of a larger discussion, but consistency leads to clarity. Anyhow, this PR is merged now. We can take up this discussion in another thread. 👍

@vlazzarini
Copy link
Member Author

I think that is a good idea to explore.

@vlazzarini vlazzarini deleted the feature/sequ branch November 1, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: can we have a kstart for sequ?

2 participants