Conversation
rorywalsh
reviewed
Nov 3, 2025
Contributor
rorywalsh
left a comment
rorywalsh
left a comment
There was a problem hiding this comment.
I'm assume it's fine to pass NULL as the init function parameter when dealing with exclusively a or k rate threads? In the previous code the init function was always passed as an argument to AppendOpcode()
Member
Author
|
it's not only OK, but it's also the only way now to guarantee the code not to run at init, perf or deinit since we removed the redundant |
rorywalsh
approved these changes
Nov 3, 2025
Contributor
rorywalsh
left a comment
rorywalsh
left a comment
There was a problem hiding this comment.
Great, thanks for clarifying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin registration had not been updated to 7.0 conventions. This PR fixes the issue.
Closes #2347