Public Calendar: Finance Hearing Timeslots Not Shown#180
Merged
Conversation
Finance hearings fetched via getFinanceHearings() were never passed to CalendarWidget on the meetings page or homepage, so they never appeared on the public calendar. Add a shared mapper (financeHearingsToCalendarEvents) that converts FinanceHearingDate entries into synthetic CalendarEvent objects (assuming a 30-minute slot, titled "Finance Hearing (Full)" when is_full is true) and merge them into the events passed to CalendarWidget on both pages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finance hearing dates are managed through a dedicated admin panel and stored as
FinanceHearingDaterecords, separate from theCalendarEventmodel. The public meetings/calendar page only fetchesCalendarEventrecords, so scheduled finance hearing timeslots never appeared on the public-facing calendar.Changes:
financeHearingsToCalendarEvents) that transformsFinanceHearingDaterecords into syntheticCalendarEvent-shaped objects (id offset to avoid collisions, 30-minute slot, title suffixed" (Full)"whenis_fullis true)CalendarWidgetFinanceHearingButtonbut never passed them to the calendarCloses #167