[Aikido] Prevent arbitrary code execution via repository-controlled gpg.program config - #46
Merged
Merged
Conversation
Keep repository-local GPG configuration separate from the global test value so the security boundary is exercised consistently on Linux and Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch addresses an arbitrary code execution vulnerability in
src-tauri/src/commands/history.rswhere the gpg.program configuration could be controlled by repository settings. The fix restricts GPG program resolution to global Git configuration only and validates that configured paths are either simple command names or existing absolute paths, rejecting relative paths that could reference repository-controlled executables. By adding agit_config_get_globalmethod to the VerificationRunner trait, the application now prevents attackers from executing arbitrary code through malicious repository configurations.