fix: preserve GVK reconciliation identity#93
Merged
Conversation
Owner
Author
|
Kubernetes object identity includes its resource type, namespace, and name. Previously, watch events queued only namespace/name, so different kinds sharing that name collapsed into the same request. Reconciliation then scanned known GVKs and used the first matching object, permanently shadowing the others. This change adds GVK to the queue identity: GVK + namespace + name. Reconciliation now fetches exactly the resource that triggered the event, with no cross-GVK scan. The fix is general, not specific to Deployments or ConfigMaps. Regression tests cover both namespaced collisions (Deployment/ConfigMap) and cluster-scoped collisions (Namespace/PersistentVolume). |
cstanislawski
marked this pull request as ready for review
July 14, 2026 20:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.