You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A restart action and its acknowledgement need to be recorded atomically.
Previously, the controller updated the pod template first, then separately removed restart-at or advanced last-restart-timestamp. A crash, conflict, lost response, or leader transition between those writes left a completed rollout looking pending, so the next reconciliation could trigger it again.
This change writes both sides of the action in one patch: restartedAt plus removal of restart-at for one-time restarts, or restartedAt plus last-restart-timestamp for recurring restarts. Stale patches fail without changing the object, then reconciliation retries from the latest version.
The fix covers both one-time and recurring restarts. Regression tests simulate a committed patch with a lost response and a concurrent update conflict, proving that each restart window is applied at most once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.